Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WSL in documentation/installation (ja) #2000

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Add WSL in documentation/installation (ja) #2000

merged 2 commits into from
Mar 25, 2019

Conversation

igaiga
Copy link
Contributor

@igaiga igaiga commented Mar 11, 2019 •
edited
Loading

  • Write descriptions for WSL(Windows Subsystem for Linux)
  • It's one of good way to use native extention gems on Windows.

@igaiga igaiga requested a review from a team as a code owner March 11, 2019 23:01
@stomar
Copy link
Contributor

stomar commented Mar 12, 2019

en is considered the main version of the site, so changes should be suggested and discussed for en first.

@igaiga igaiga mentioned this pull request Mar 19, 2019
Merged
@igaiga igaiga force-pushed the add_wsl_in_ja_ducumentation_installation branch from 430e11e to 669b8e2 Compare March 21, 2019 23:22
@igaiga igaiga force-pushed the add_wsl_in_ja_ducumentation_installation branch from 669b8e2 to ed4fba5 Compare March 21, 2019 23:26
@igaiga
Copy link
Contributor Author

igaiga commented Mar 21, 2019 •
edited
Loading

@sho-h @znz
Could you review the PR?
English page: #2009
The page structure is different from en page, so adopting ja page style.
And I'll update apt and Package Management Systems descriptions in next PR.

@znz
Copy link
Member

znz commented Mar 23, 2019

@igaiga
#2009 added Windows WSL Ubuntu under Package Management Systems, but this PR added WSL under Windows.
I think same structure is easy to maintenance.

Windows Subsystem for Linux Installation Guide for Windows 10 is English page.
I think link to Japanese page is better if exists.

@sho-h
Copy link
Contributor

sho-h commented Mar 23, 2019

@igaiga I have no additional opinion with @znz san's comment. 👍

@igaiga
Copy link
Contributor Author

igaiga commented Mar 23, 2019

@znz OK, I'll move the contents to Package Management Systems. And English page and Japanese page has different structures. Top category of Japanese page is platform(like Windows), but English page has no category of platform. So I think it's good adding WSL into the platform category.

@igaiga
Copy link
Contributor Author

igaiga commented Mar 23, 2019

And there is no ja page in docs.icrosoft.com
https://docs.microsoft.com/ja-jp/windows/wsl/install-win10
link redirect to en page.

@igaiga
Copy link
Contributor Author

igaiga commented Mar 25, 2019

@JuanitoFatas Could you check this?

@JuanitoFatas JuanitoFatas merged commit cbfb959 into ruby:master Mar 25, 2019
@JuanitoFatas
Copy link
Member

Thanks igaiga-san and everyone who reviewed <3

@igaiga igaiga deleted the add_wsl_in_ja_ducumentation_installation branch March 26, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sho-h sho-h sho-h approved these changes

@znz znz znz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igaiga @stomar @znz @sho-h @JuanitoFatas