Add WSL in en/documentation/installation (en) #2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igaiga
commented
Mar 19, 2019
igaiga
commented
- Writing descriptions for WSL(Windows Subsystem for Linux)
- It's one of good way to use native extention gems on Windows.
- It's difficult to choose where the sentences placed. We can move them if there are better ideas.
- I'm not a native English speaker, so I hope the sentences would be fixed before merging.
- Japanses PR: Add WSL in documentation/installation (ja) #2000
JuanitoFatas
approved these changes
Mar 19, 2019
|
@JuanitoFatas Thanks!! |
|
Besides the language, which should have been fixed as requested before merging, there were several shortcomings with this addition. I fixed it with 81f27a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.