-
Notifications
You must be signed in to change notification settings - Fork 632
Add rvm-windows to installation doc #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rvm-windows to installation doc #3250
Conversation
Except for trailing white space. Spanish is good. |
…umentation' into feature-add_rvm_4_windows_to_documentation # Conflicts: # es/documentation/installation/index.md
@vtamara trailing whitespaces removed |
### RVM 4 Windows | ||
{: #rvm-windows} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RVM 4 Windows
should be added to TOC between "RVM" and "uru."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to make it analogous to "rbenv for windows", which also does not have its own entry in TOC, but follows "rbenv". So does "RVM 4 Windows" follow "RVM".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I understand.
Hey guys, for me it looks like, that many languages are even not maintained anymore, as no more reviews happend within one month. So, would you suggest me, to make a new PR only with Korean and English? Or is there a chance to get this PR ever merged without all languages reviewed? |
As there are lots of language reviewers not active anymore, this Pull Request will never succeed all reviews. So i decided to make a new one with English only and close this one. New Pull Request with English only: #3425 |
Add the new RVM 4 Windows to the list of Ruby version managers at the installation documentation.
Included languages are
bg de en es fr id it ja ko pl pt ru tr zh_cn