Skip to content

Translate "First pass at updating en/documentation/index.md" (ko) #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

riseshia
Copy link
Member

@riseshia riseshia commented Jan 4, 2025

🔗 #3461

Translation of #3427

Actual diff is 08de124

@riseshia riseshia force-pushed the update-documentation-index branch from 73298a6 to 08de124 Compare January 4, 2025 04:36
@riseshia riseshia marked this pull request as ready for review January 4, 2025 04:37
@riseshia riseshia requested a review from a team as a code owner January 4, 2025 04:37
@riseshia riseshia mentioned this pull request Jan 4, 2025
18 tasks
Comment on lines -159 to -161
[ko-3]: https://groups.google.com/forum/#!forum/rubykr
[ko-4]: https://www.facebook.com/groups/rubykr/
[ko-5]: http://ruby-korea.github.io/#book
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that ko-3, ko-4 links are still available, but I'm not sure where they should be.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, It's better to move these to "User groups" (community/user-groups/index.md) if we want leave this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be appropriate!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's handle this with seperate PR #3461 (comment)

riseshia and others added 5 commits January 12, 2025 09:12
which is moved to "오래된 문서"
Co-authored-by: Chayoung You <yousbe@gmail.com>
Co-authored-by: Chayoung You <yousbe@gmail.com>
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riseshia
Copy link
Member Author

Thanks! When #3468 is merged, I'll apply its finalized changes and merge.

@riseshia riseshia force-pushed the update-documentation-index branch from 35b9009 to 683b99e Compare January 17, 2025 00:24
@riseshia
Copy link
Member Author

Apply update for #3468 on 683b99e

@riseshia riseshia merged commit 59ca2c7 into ruby:master Jan 17, 2025
1 check passed
@riseshia riseshia deleted the update-documentation-index branch January 17, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants