Fix ruby-lsp url on documentation index #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yous
approved these changes
Jan 12, 2025
st0012
reviewed
Jan 12, 2025
en/documentation/index.md
Outdated
| @@ -241,6 +241,6 @@ These links were more prominent but haven't been updated in ages. | |||
| [ruby-lsp]: https://github.com/Shopify/ruby-lsp | |||
| [rubyapi-org]: https://rubyapi.org/ | |||
| [rubyin20]: https://www.ruby-lang.org/en/documentation/quickstart/ | |||
| [shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html) | |||
| [shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html | |||
There was a problem hiding this comment.
I know this will be different fix, but IMO this should be called ruby-lsp-supported-editors and be placed under ruby-lsp (line 242).
st0012
reviewed
Jan 15, 2025
en/documentation/index.md
Outdated
| @@ -239,8 +239,8 @@ These links were more prominent but haven't been updated in ages. | |||
| [pickaxe]: https://pragprog.com/titles/ruby5/programming-ruby-3-3-5th-edition/ | |||
| [poodr]: https://www.poodr.com/ | |||
| [ruby-lsp]: https://github.com/Shopify/ruby-lsp | |||
| [shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html | |||
There was a problem hiding this comment.
The project isn't called Shopify LSP so let's change the name:
Suggested change
| [shopify_lsp]: https://shopify.github.io/ruby-lsp/editors.html | |
| [ruby-lsp-supported-editors]: https://shopify.github.io/ruby-lsp/editors.html |
Remember to update all the references to it too 🙂
There was a problem hiding this comment.
oops I missed it. fixed 070401d
jeremyevans
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA