Fix dashboard recently added useers (#3473) #3529
Conversation
|
Thank you @Isaac-alencar! This will make it easier for us to do some of our support tasks regarding newly added users. Just to manage expectations -- due to the holidays, it might be next week before someone gets around to reviewing this (or it might be today - I can't be sure). |
app/views/admin/dashboard.html.erb
Outdated
| <%= link_to user.email, edit_admin_user_path(user), class: "users-list-name" %> | ||
| <% else %> | ||
| <%= link_to user.name, edit_admin_user_path(user), class: "users-list-name" %> | ||
| <% end %> |
There was a problem hiding this comment.
This can be bunched together to be one line:
<%= link_to user.name.presence || user.email, edit_admin_user_path(user), class: "users-list-name" %>
There was a problem hiding this comment.
I decided to create a helper in order to do it, since we have a default value for the name field. So, when the name it is equal to "Name Not Provided" we display email otherwise the real name
|
@dorner thanks for reviewing! I'll fix it in a bit |
There was a problem hiding this comment.
@Isaac-alencar just one minor suggestion - otherwise it looks good!
app/helpers/dashboard_helper.rb
Outdated
| @@ -40,6 +40,10 @@ def future_distributed | |||
| number_with_delimiter future_distributed_unformatted | |||
| end | |||
|
|
|||
| def recently_added_user_display_text(user) | |||
| (user.name.presence == "Name Not Provided") ? user.email : user.name | |||
There was a problem hiding this comment.
You don't need presence here because nil will by definition not equal the given string :) You also don't need the additional parentheses.
user.name == 'Name Not Provided' ? user.email : user.nameThere was a problem hiding this comment.
You don't need
presencehere becausenilwill by definition not equal the given string :) You also don't need the additional parentheses.user.name == 'Name Not Provided' ? user.email : user.name
It seems like the lint is failing without the parentheses
Isaac-alencar
force-pushed
the
fix-dashboard-recently-added-useers
branch
from
d7819e5
to
403e3cf
Compare
|
Awesome, thanks! |
|
Hey @Isaac-alencar -- Just letting you know this is in production now. Congratulations on your first human-essentials contribution that has made it to the real world! |
Resolves #3473
Description
In this PR, I fixed the superuser dashboard section "Recently added users" to display an email instead of "No Provided Name" and limited the total users displayed in this section to 20. Also, now the email text it is a link to edit user path as required in the issue.
Type of change
How Has This Been Tested?
Tests are located in
admin_request_spec.rbfrom lines 21 to 36Screenshots