Change button from 'Promote to Admin' to 'Edit User' #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dorner Can you take a technical pass on this one, please? |
dorner
requested changes
Oct 6, 2024
| @@ -151,5 +153,15 @@ | |||
| expect(page).to have_content("Default email text") | |||
| expect(page).to have_content("Users") | |||
| end | |||
|
|
|||
| it "can edit a user within an organization" do | |||
There was a problem hiding this comment.
I don't think we need a full system spec for this - you can just validate the button in the HTML in a request spec.
|
Removed the system spec and added a request spec as suggested. |
|
@leslie-seeberger: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4664
Description
Changed the 'Promote to Admin' button to 'Edit User', allowing the super admin to change the user's role from the admin/users/edit page.
Type of change
How Has This Been Tested?