Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partner group to organization. Add new partner for seed #4708

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

lit-poks
Copy link
Contributor

@lit-poks lit-poks commented Oct 7, 2024

Resolves #4679

Description

  • Add to the seed a partner group, "Group 2", that has all the item categories in "Pawnee Diaper Bank" organization
  • Add a new partner "Second Street Community Outreach"

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested this by following these setps:
    • Login as org_admin1@example.com
    • Go to Inventory > Items and Inventory
    • Go to the item categories tab and check if all 3 categories of the organization exists
  • Tested the creation of partner by logging in and checking if it exists in all partners

Screenshots

image image

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lit-poks -- This looks great!

We neglected to include, in the issue, adding the new partner into the information in the contributing.md. Would you mind making that change as well -- it goes hand-in-hand with what you've done. This would be under the "Credentials" section in contributing.md, and the lines to add would be:

Another approved partner (with all groups):
Email: approved_2@example.com
Pasword: password!

If you don't have the cycles to do that, let me know, and I'll get someone else to do it.
Thanks!

@lit-poks
Copy link
Contributor Author

lit-poks commented Oct 9, 2024

@cielf , added the details to CONTRIBUTING.md as well. please review

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit dd22a1f into rubyforgood:main Oct 10, 2024
12 checks passed
Copy link
Contributor

@lit-poks: Your PR Add partner group to organization. Add new partner for seed is part of today's Human Essentials production release: 2024.10.13.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a partner group to seed that has all the categories, and add an approved partner that is in that group.
2 participants