Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4523: Fix user info disappearing on validation failure for new org requests #4779

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Nov 13, 2024

Resolves #4523

Description

Fixes issue where user info would disappear when creating new organizations from an account request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually locally and added a request spec.

@coalest coalest force-pushed the 4523-fix-users-disappearing-on-error-account-requests branch from 717fcc4 to c900753 Compare November 13, 2024 10:30
@coalest coalest force-pushed the 4523-fix-users-disappearing-on-error-account-requests branch from c900753 to 4597632 Compare November 13, 2024 10:57
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a functional pov. Any technical comments, @dorner?

@cielf cielf requested a review from dorner November 15, 2024 19:50
@dorner dorner merged commit e8dd85d into rubyforgood:main Nov 16, 2024
11 checks passed
@dorner
Copy link
Collaborator

dorner commented Nov 16, 2024

Awesome, thanks!

Copy link
Contributor

@coalest: Your PR 4523: Fix user info disappearing on validation failure for new org requests is part of today's Human Essentials production release: 2024.11.17.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Requests - Fix Users disappearing on error
3 participants