Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set new single throttle policy for gem push #2268

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Set new single throttle policy for gem push #2268

merged 1 commit into from
Mar 17, 2020

Conversation

colby-swandale
Copy link
Member

@colby-swandale colby-swandale commented Mar 17, 2020 •
edited by dwradcliffe
Loading

The current policy has a couple of issues:

  • The current back-off calculation is very incorrect, if a gem author reaches level 3, they have to wait 216000000 seconds (6 years) before being allowed to upload a gem again
  • Limits legitimate high traffic authors from uploading new versions of their gems

This PR changes the gem push throttle policy to be only a single rule, 150 gems pushes per hour.

@colby-swandale
Set new single trottle policy for gem push
e78ff56 
New trottle policy is 150 gem pushes per hour
@colby-swandale colby-swandale merged commit 9ee71da into master Mar 17, 2020
@colby-swandale colby-swandale deleted the colby/gem-push-limit branch March 17, 2020 02:59
@colby-swandale colby-swandale temporarily deployed to staging March 17, 2020 03:13 Inactive
@colby-swandale colby-swandale temporarily deployed to production March 17, 2020 03:46 Inactive
@alextwoods alextwoods mentioned this pull request Mar 17, 2020
Closed
@sonalkr132 sonalkr132 mentioned this pull request Apr 7, 2020
Merged
@sonalkr132 sonalkr132 mentioned this pull request Jun 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwradcliffe dwradcliffe dwradcliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colby-swandale @dwradcliffe