Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new single throttle policy for gem push #2268

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Set new single throttle policy for gem push #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions config/initializers/rack_attack.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
class Rack::Attack
REQUEST_LIMIT = 100
PUSH_LIMIT = 150
REQUEST_LIMIT_PER_EMAIL = 10
LIMIT_PERIOD = 10.minutes
PUSH_LIMIT_PERIOD = 60.minutes

### Prevent Brute-Force Login Attacks ###

Expand Down Expand Up @@ -60,16 +62,10 @@ def self.protected_route?(protected_actions, path, method)
end
end

PUSH_LIMIT = 150
protected_push_action = [{ controller: "api/v1/rubygems", action: "create" }]

# 150 push in 10 min
# 450 push in 1000 min
# 600 push in 10000 min
[1, 3, 4].each do |level|
throttle("api/push/ip/#{level}", limit: PUSH_LIMIT * level, period: (LIMIT_PERIOD**level).seconds) do |req|
req.ip if protected_route?(protected_push_action, req.path, req.request_method)
end
throttle("api/push/ip", limit: PUSH_LIMIT, period: PUSH_LIMIT_PERIOD) do |req|
req.ip if protected_route?(protected_push_action, req.path, req.request_method)
end

# Throttle GET request for api_key by IP address
Expand Down
14 changes: 9 additions & 5 deletions test/integration/rack_attack_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ def limit_period
Rack::Attack::LIMIT_PERIOD
end

def push_limit_period
Rack::Attack::PUSH_LIMIT_PERIOD
end

def exceed_limit_for(scope)
update_limit_for("#{scope}:#{@ip_address}", exceeding_limit)
end
Expand All @@ -39,7 +43,7 @@ def exceed_email_limit_for(scope)

def exceed_push_limit_for(scope)
exceeding_push_limit = (Rack::Attack::PUSH_LIMIT * 1.25).to_i
update_limit_for("#{scope}:#{@ip_address}", exceeding_push_limit)
update_limit_for("#{scope}:#{@ip_address}", exceeding_push_limit, push_limit_period)
end

def stay_under_limit_for(scope)
Expand All @@ -55,8 +59,8 @@ def stay_under_push_limit_for(scope)
update_limit_for("#{scope}:#{@user.email}", under_push_limit)
end

def update_limit_for(key, limit)
limit.times { Rack::Attack.cache.count(key, limit_period) }
def update_limit_for(key, limit, period = limit_period)
limit.times { Rack::Attack.cache.count(key, period) }
end

def exceed_exponential_limit_for(scope, level)
Expand Down Expand Up @@ -143,7 +147,7 @@ def encode(username, password)
end

should "allow gem push by ip" do
stay_under_push_limit_for("api/push/ip/1")
stay_under_push_limit_for("api/push/ip")

post "/api/v1/gems",
params: gem_file("test-1.0.0.gem").read,
Expand Down Expand Up @@ -331,7 +335,7 @@ def encode(username, password)
end

should "throttle gem push by ip" do
exceed_push_limit_for("api/push/ip/1")
exceed_push_limit_for("api/push/ip")

post "/api/v1/gems",
params: gem_file("test-1.0.0.gem").read,
Expand Down