Add support for Rails 7.2 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.6.4 doesn't actually support Rails 7.2, so drop this item from the changelog.
Closed
radar
approved these changes
Aug 13, 2024
|
Checks all passing. Thank you @andrewhampton. |
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| ## 2.6.4 - July 20, 2024 | |||
|
|
|||
| Add support for [Rails 7.2](https://github.com/rails/rails/releases/tag/v7.2.0) | |||
There was a problem hiding this comment.
the 3 PRs listed below was about supporting changes in 7.2, thus that title here
There was a problem hiding this comment.
Ah, 2.6.4 didn't actually support 7.2. That combined with seeing this comment made me think this line was added by mistake. So I removed it as part of this PR.
There was a problem hiding this comment.
make sense, I should have been more clear about it. I could not bump the version until it was officially released. but those were preliminary fix that was shown to be required for those using the pre-release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Rails 7.2.
Everything is pretty straightforward with the exception of the required version of
sqlite3. I see theSQLITE_VERSIONenv var can be used to specify a specific version of sqlite3, so maybe I should use that for testing rails 7.2?closes #562