-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rails 8.0 #572
base: core
Are you sure you want to change the base?
Conversation
chenillen
commented
Dec 5, 2024
- add support to 8.0
- add a test all file for 6.1 - 8.0 version
@@ -0,0 +1 @@ | |||
3.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why we need this file, especially with .0
...
@@ -1,7 +1,7 @@ | |||
require 'active_record' unless defined? ActiveRecord | |||
|
|||
if [ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR] == [5, 2] || | |||
ActiveRecord::VERSION::MAJOR > 5 | |||
ActiveRecord::VERSION::MAJOR >= 6 | |||
require 'paranoia/active_record_5_2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at this change, this looks badly named... do we need this patch for rails 6, 7 and 8 ?
@@ -20,7 +21,7 @@ if RUBY_ENGINE == 'rbx' | |||
end | |||
end | |||
|
|||
rails = ENV['RAILS'] || '~> 6.0.4' | |||
rails = ENV['RAILS'] || '~> 6.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could move up the rails
initialization, before sqlite
and use the var instead, but I can see how its equivalent. so maybe its OK as-is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks like good changes... I only have minor comments... but the title is miss-leading. this isn't adding support for Rails 8. it's only fixing small things and adding a script. Support for 8 is already merged in #563