Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Accessing dead object error in Firefox #567

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Fix: Accessing dead object error in Firefox #567

merged 5 commits into from
Jul 21, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Jul 18, 2022 •
edited by SumanthPuram
Loading

Description of the change

Added error handling for accessing dead object error in Firefox

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner July 18, 2022 06:43
saikumarrs
saikumarrs reviewed Jul 18, 2022
View reviewed changes
utils/utils.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs reviewed Jul 18, 2022
View reviewed changes
utils/utils.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs reviewed Jul 18, 2022
View reviewed changes
utils/utils.js Outdated Show resolved Hide resolved
MoumitaM and others added 2 commits July 18, 2022 18:39
@MoumitaM @saikumarrs
Update utils/utils.js
30c23dc 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
code refactoring
11dd652
@MoumitaM MoumitaM requested a review from saikumarrs July 18, 2022 15:07
saikumarrs
saikumarrs reviewed Jul 18, 2022
View reviewed changes
utils/utils.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs reviewed Jul 18, 2022
View reviewed changes
utils/utils.js Outdated Show resolved Hide resolved
MoumitaM and others added 2 commits July 18, 2022 23:43
@MoumitaM @saikumarrs
Update utils/utils.js
4418e3d 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update utils/utils.js
3b0d3ac 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM MoumitaM requested a review from saikumarrs July 19, 2022 05:19
@saikumarrs saikumarrs merged commit 4274f06 into v1-staging Jul 21, 2022
@saikumarrs saikumarrs deleted the fix/dead-obj-firefox branch July 21, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs