Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Accessing dead object error in Firefox #567

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Fix: Accessing dead object error in Firefox #567

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0958cf
added error handling for dead obj accessing error
MoumitaM Jul 18, 2022
30c23dc
Update utils/utils.js
MoumitaM Jul 18, 2022
11dd652
code refactoring
MoumitaM Jul 18, 2022
4418e3d
Update utils/utils.js
MoumitaM Jul 18, 2022
3b0d3ac
Update utils/utils.js
MoumitaM Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,14 @@ function getDefaultPageProperties() {
}

function getReferrer() {
return document.referrer || "$direct";
// This error handling is in place to avoid accessing dead object(document)
const defaultReferrer = "$direct";
try {
return document.referrer || referrer;
} catch (e) {
logger.error("Error trying to access 'document.referrer': ", e);
return referrer;
}
}

function getReferringDomain(referrer) {
Expand Down