chore: preferAppend defaults to false if not defined #4088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achettyiitr @lvrach I'm proposing this approach. I have not updated the tests just yet, I'm just showcasing the changes here. Once I get a green light from everybody (product and CS as well) then I can update the tests. Let me know if it doesn't make sense somehow. |
lvrach
reviewed
Nov 7, 2023
fracasula
changed the title
fracasula
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4088 +/- ##
==========================================
- Coverage 71.98% 71.96% -0.03%
==========================================
Files 372 372
Lines 54831 54838 +7
==========================================
- Hits 39472 39464 -8
- Misses 13059 13069 +10
- Partials 2300 2305 +5
☔ View full report in Codecov by Sentry. |
achettyiitr
approved these changes
Nov 8, 2023
|
Closing in favour of #4098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to this PR where we changed the default behaviour for Warehouse destinations so that users would have to opt-in if they want to merge (aka remove duplicates).
Given that the UI changes for enabling the merge are not live we're setting
enableMergeby default totrueif it's not set. This maintains backwards compatibility and allows us to decouple the data plane deployment from the control plane one.Linear Ticket
< Linear Link >
Security