chore: preferAppend defaults to false if not defined

warehouse/integrations/bigquery/bigquery.go

@@ -867,7 +867,7 @@ func (bq *BigQuery) connect(ctx context.Context, cred BQCredentials) (*bigquery.
 // * the server config says we allow merging
 // * the user opted in to merging
 func (bq *BigQuery) shouldMerge() bool {
- return bq.config.allowMerge && bq.warehouse.GetBoolDestinationConfig(model.EnableMergeSetting)
+ return bq.config.allowMerge && bq.warehouse.GetEnableMergeSetting()
 }
 
 func (bq *BigQuery) CrashRecover(ctx context.Context) {

warehouse/integrations/deltalake/deltalake.go

@@ -1387,5 +1387,5 @@ func (*Deltalake) DeleteBy(context.Context, []string, warehouseutils.DeleteByPar
 // * the user opted in to merging and we allow merging
 func (d *Deltalake) ShouldMerge() bool {
  return !d.Uploader.CanAppend() ||
- (d.config.allowMerge && d.Warehouse.GetBoolDestinationConfig(model.EnableMergeSetting))
+ (d.config.allowMerge && d.Warehouse.GetEnableMergeSetting())
 }

warehouse/integrations/postgres/load.go

@@ -556,6 +556,6 @@ func (pg *Postgres) loadUsersTable(
 func (pg *Postgres) shouldMerge() bool {
  return !pg.Uploader.CanAppend() ||
  (pg.config.allowMerge &&
- pg.Warehouse.GetBoolDestinationConfig(model.EnableMergeSetting) &&
+ pg.Warehouse.GetEnableMergeSetting() &&
  !slices.Contains(pg.config.skipDedupDestinationIDs, pg.Warehouse.Destination.ID))
 }

warehouse/integrations/redshift/redshift.go

@@ -1329,7 +1329,7 @@ func (rs *Redshift) SetConnectionTimeout(timeout time.Duration) {
 func (rs *Redshift) shouldMerge() bool {
  return !rs.Uploader.CanAppend() ||
  (rs.config.allowMerge &&
- rs.Warehouse.GetBoolDestinationConfig(model.EnableMergeSetting) &&
+ rs.Warehouse.GetEnableMergeSetting() &&
  !slices.Contains(rs.config.skipDedupDestinationIDs, rs.Warehouse.Destination.ID))
 }
 

warehouse/integrations/snowflake/snowflake.go

@@ -829,7 +829,7 @@ func (sf *Snowflake) LoadIdentityMappingsTable(ctx context.Context) error {
 // * the user opted-in
 func (sf *Snowflake) ShouldMerge() bool {
  return !sf.Uploader.CanAppend() ||
- (sf.config.allowMerge && sf.Warehouse.GetBoolDestinationConfig(model.EnableMergeSetting))
+ (sf.config.allowMerge && sf.Warehouse.GetEnableMergeSetting())
 }
 
 func (sf *Snowflake) LoadUserTables(ctx context.Context) map[string]error {

warehouse/internal/model/warehouse.go

@@ -31,3 +31,12 @@ func (w *Warehouse) GetBoolDestinationConfig(key DestinationConfigSetting) bool
  }
  return false
 }
+
+func (w *Warehouse) GetEnableMergeSetting() bool {
+ destConfig := w.Destination.Config
+ value, ok := destConfig[EnableMergeSetting.string()].(bool)
+ if !ok {
+ return true // default value for backwards compatibility
+ }
+ return value
+}