Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes for supporting record event in FB audience #3351

Merged
merged 17 commits into from
Jun 5, 2024

Conversation

Vikas26021999
Copy link
Contributor

@Vikas26021999 Vikas26021999 commented May 8, 2024

What are the changes introduced in this PR?

changes for supporting record event in FB audience

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Vikas26021999 Vikas26021999 requested a review from a team as a code owner May 8, 2024 09:02
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.02%. Comparing base (cd0b81b) to head (be23c39).
Report is 3 commits behind head on develop.

Files Patch % Lines
...destinations/fb_custom_audience/recordTransform.js 92.66% 8 Missing ⚠️
...rc/v0/destinations/fb_custom_audience/transform.js 88.00% 3 Missing ⚠️
src/v0/destinations/fb_custom_audience/util.js 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3351      +/-   ##
===========================================
+ Coverage    88.01%   88.02%   +0.01%     
===========================================
  Files          569      570       +1     
  Lines        30634    30772     +138     
  Branches      7323     7352      +29     
===========================================
+ Hits         26961    27088     +127     
+ Misses        3366     3349      -17     
- Partials       307      335      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai requested a review from ItsSudip May 8, 2024 10:14
Copy link
Member

@yashasvibajpai yashasvibajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add tests too. :)

  1. SImple insert record
  2. Simple delete record
  3. Simple update record
  4. Batching multiple record events with a custom batch size config
  5. Failure scenarios like instrumentation errors etc

@Vikas26021999 Vikas26021999 requested review from sivashanmukh and a team as code owners May 17, 2024 08:49
yashasvibajpai
yashasvibajpai previously approved these changes May 18, 2024
yashasvibajpai
yashasvibajpai previously approved these changes May 20, 2024
ItsSudip
ItsSudip previously approved these changes May 20, 2024
@Vikas26021999 Vikas26021999 dismissed stale reviews from ItsSudip and yashasvibajpai via ad86160 May 28, 2024 08:43
Copy link

sonarqubecloud bot commented Jun 4, 2024

@Vikas26021999 Vikas26021999 merged commit ac4a32a into develop Jun 5, 2024
16 checks passed
@Vikas26021999 Vikas26021999 deleted the feat.FBRecordEvent branch June 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants