Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set CARGO_NET_GIT_FETCH_WITH_CLI=true on Windows (and incidentally on Linux) #15325

Closed
wants to merge 1 commit into from

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Feb 26, 2024

This step takes almost 3 minutes on our Windows CI runs.
Inspiration: rust-lang/cargo#9167

I could have also added this to .cargo/config.toml, as with #15324 (or vice versa, set that using an envvar); but considered that to be more generally useful and less risky, while this may not be useful for everyone, and adds a dependency to git being available as a command.

@torokati44
Copy link
Member Author

Well, it only brought that step down from ~135 to ~110 seconds.
I'm not sure it's worth it then.
But maybe...?

@torokati44
Copy link
Member Author

No substantial speedup observed... :/
https://github.com/torokati44/ruffle/actions/runs/8051740050/job/21990316922

That step is either "near-instant", or takes about 2 minutes, as before.
Seems like any kind of FS operations involving lots of tiny files is indeed just hopelessly slow on Windows, no matter what library or program does them...
Anyway, it was worth a try. I hope at least it did in fact take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant