Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Stop sounds attached to an unloaded root movie #18516

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Toad06
Copy link
Member

@Toad06 Toad06 commented Nov 7, 2024

... instead of doing this for each unloaded display object.

Fixes #18327.
Fixes #18181.
Fixes #18057.
Fixes #17718.
Fixes #17395.
This should fix #17059 as well... but I'm not sure where the issues are supposed to be. 😅

I also checked against the files mentioned in #17016 and can confirm that they continue to stop sounds as expected. However, I was unable to test #16947 due to the web server being down. For #963, I tested it on FlashArch, since the file appears to be no longer accessible on the official site.

Super Monkey Ball Mini is an interesting test case, as it experienced both issues in sequence:

  • Before #17016, the music from the title screen continued playing when entering a level instead of stopping.
  • After #17016, while the title screen music did stop correctly, some sound effects unexpectedly stopped (for example, when clicking on a level index) or failed to play altogether (such as the "Go" sound when starting a level).

@Toad06 Toad06 added A-avm1 Area: AVM1 (ActionScript 1 & 2) waiting-on-review Waiting on review from a Ruffle team member T-fix Type: Bug fix (in something that's supposed to work already) labels Nov 7, 2024
@torokati44
Copy link
Member

Thank you! 🚀

@torokati44 torokati44 merged commit a255bc6 into ruffle-rs:master Nov 9, 2024
22 checks passed
@Toad06
Copy link
Member Author

Toad06 commented Nov 10, 2024

Thanks for the review and merge!

@Toad06 Toad06 deleted the audio branch November 10, 2024 11:33
@Toad06 Toad06 removed the waiting-on-review Waiting on review from a Ruffle team member label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) newsworthy T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
4 participants