avm2: Enable stack traces for Flash Player 11.5+ and SWF18+ #19571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
adrian17
approved these changes
Feb 19, 2025
n0samu
suggested changes
Feb 19, 2025
There was a problem hiding this comment.
Despite what the docs say, this behavior also seems to depend on the SWF version. Notice that the attached SWF displays no stack trace in release FP: StackTraceTest.zip. But if you change the SWF version to 18 or higher in JPEXS, then the stack trace appears.
Also, be sure to test #12572 since it is affected by the behavior of getStackTrace().
kjarosh
force-pushed
the
avm2-stacktraces
branch
from
7c4df88 to
aea9328
Compare
kjarosh
changed the title
This option specifies whether to emulate flashplayer (release mode) or flashplayerdebugger (debug mode).
For Flash Player 11.5+ and SWF18+, stack traces are always enabled. Some content uses this behavior to verify whether the user is using Flash Player 11.5 onwards. For Flash Player 11.4 and earlier or SWF<18, stack traces are enabled only in the debug build. See <https://docs.ruffle.rs/en_US/FlashPlatform/reference/actionscript/3/Error.html#getStackTrace()>
These tests check whether stack traces are returned based on the SWF version and the debug/release mode.
kjarosh
force-pushed
the
avm2-stacktraces
branch
from
aea9328 to
7eb20de
Compare
n0samu
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Flash Player 11.5+ and SWF18+, stack traces are always enabled. Some content uses this behavior to verify whether the user is using Flash Player 11.5 onwards.
See https://docs.ruffle.rs/en_US/FlashPlatform/reference/actionscript/3/Error.html#getStackTrace()
Related:
Info#10310CC @adrian17 @Lord-McSweeney