Skip to content

Commit

Permalink
create run_name for get_call http route if not specified (#1182)
Browse files Browse the repository at this point in the history
We're not setting a `run_name` on the `get_call` endpoint. This comes up when [calling a function via CURL](https://github.com/run-house/runhouse/actions/runs/10487756209/job/29048800796).

This update creates a run name if not provided in the request
  • Loading branch information
jlewitt1 committed Aug 21, 2024
1 parent aed9e71 commit 7e1d023
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion runhouse/servers/http/http_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,9 @@ async def get_call(
# Default argument to json doesn't allow a user to pass in a serialization string if they want
# But, if they didn't pass anything, we want it to be `json` by default.
serialization = serialization or "json"

try:
if run_name is None:
run_name = f"{key}_{method_name}_{serialization}_{remote}"

# The types need to be explicitly specified as parameters first so that
# we can cast Query params to the right type.
Expand Down

0 comments on commit 7e1d023

Please sign in to comment.