Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create run_name for get_call http route if not specified #1182

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Aug 21, 2024

We're not setting a run_name on the get_call endpoint. This comes up when calling a function via CURL.

This update creates a run name if not provided in the request

Copy link
Collaborator Author

jlewitt1 commented Aug 21, 2024

@jlewitt1 jlewitt1 marked this pull request as ready for review August 21, 2024 10:47
@jlewitt1 jlewitt1 requested a review from rohinb2 August 21, 2024 10:47
Copy link
Contributor

@rohinb2 rohinb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good, gonna stack one more minor thing on top

Copy link

graphite-app bot commented Aug 21, 2024

Mustache GIF (Added via Giphy)

Copy link

graphite-app bot commented Aug 21, 2024

Graphite Automations

"rohin" took an action on this PR • (08/21/24)

1 gif was posted to this PR based on Rohin Bhasin's automation.

Copy link
Contributor

rohinb2 commented Aug 21, 2024

Merge activity

  • Aug 21, 10:17 AM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Aug 21, 10:17 AM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 merged commit 7e1d023 into main Aug 21, 2024
12 of 13 checks passed
@rohinb2 rohinb2 deleted the run-name-for-call-method branch August 21, 2024 14:17
carolineechen pushed a commit that referenced this pull request Aug 21, 2024
We're not setting a `run_name` on the `get_call` endpoint. This comes up when [calling a function via CURL](https://github.com/run-house/runhouse/actions/runs/10487756209/job/29048800796).

This update creates a run name if not provided in the request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants