-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create run_name
for get_call
http route if not specified
#1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
run-name-for-call-method
branch
from
August 21, 2024 10:32
2ec636c
to
4c53978
Compare
rohinb2
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, gonna stack one more minor thing on top
Graphite Automations"rohin" took an action on this PR • (08/21/24)1 gif was posted to this PR based on Rohin Bhasin's automation. |
carolineechen
pushed a commit
that referenced
this pull request
Aug 21, 2024
We're not setting a `run_name` on the `get_call` endpoint. This comes up when [calling a function via CURL](https://github.com/run-house/runhouse/actions/runs/10487756209/job/29048800796). This update creates a run name if not provided in the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not setting a
run_name
on theget_call
endpoint. This comes up when calling a function via CURL.This update creates a run name if not provided in the request