Install preferred version only if package is not already installed. #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Comment on lines
+11
to
+15
| def get_bs4_version(): | ||
| import bs4 | ||
|
|
||
| return plotly.__version__ | ||
| return bs4.__version__ |
There was a problem hiding this comment.
Are we gonna rotate this every time you change the instal logic pal
There was a problem hiding this comment.
Also can you add it to test/requirements.txt, otherwise will break when people try to run this test
dongreenberg
approved these changes
Jul 23, 2024
Base automatically changed from
07-23-Remove_unused_Package_helper_functions
to
main
July 23, 2024 21:38
rohinb2
force-pushed
the
07-23-Install_preferred_version_only_if_package_is_not_already_installed
branch
from
f192d78
to
5953635
Compare
rohinb2
force-pushed
the
07-23-Install_preferred_version_only_if_package_is_not_already_installed
branch
from
5953635
to
7ea23ec
Compare
rohinb2
force-pushed
the
07-23-Install_preferred_version_only_if_package_is_not_already_installed
branch
2 times, most recently
from
2943a93
to
c36c1aa
Compare
rohinb2
changed the base branch from
main
to
08-21-Add_check_for_stream_logs_True_and_generate_run_name_differently
This was referenced Aug 21, 2024
rohinb2
changed the base branch from
08-21-Add_check_for_stream_logs_True_and_generate_run_name_differently
to
graphite-base/1058
rohinb2
force-pushed
the
07-23-Install_preferred_version_only_if_package_is_not_already_installed
branch
from
c36c1aa
to
c8861ee
Compare
rohinb2
deleted the
07-23-Install_preferred_version_only_if_package_is_not_already_installed
branch
carolineechen
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.