Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simplified default logger #1177

Merged
merged 6 commits into from
Aug 28, 2024
Merged

use simplified default logger #1177

merged 6 commits into from
Aug 28, 2024

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Aug 20, 2024

Note: CI not passing here (it is in #1178), but wanted to split up for an easier review

Copy link
Collaborator Author

jlewitt1 commented Aug 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jlewitt1 and the rest of your teammates on Graphite Graphite

@jlewitt1 jlewitt1 force-pushed the update-default-logger branch 2 times, most recently from e5eb1f0 to 2cb2773 Compare August 20, 2024 19:16
@jlewitt1 jlewitt1 marked this pull request as ready for review August 27, 2024 10:55
Copy link
Contributor

@rohinb2 rohinb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

Copy link

graphite-app bot commented Aug 27, 2024

Like It Yes GIF by Nový start (Added via Giphy)

Copy link

graphite-app bot commented Aug 27, 2024

Graphite Automations

"rohin" took an action on this PR • (08/27/24)

1 gif was posted to this PR based on Rohin Bhasin's automation.

Copy link
Contributor

@rohinb2 rohinb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Conflicts:
#	examples/airflow-torch-training/callables.py
Copy link
Contributor

rohinb2 commented Aug 27, 2024

Merge activity

  • Aug 27, 5:50 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Aug 27, 5:50 PM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@jlewitt1 jlewitt1 merged commit c2f7691 into main Aug 28, 2024
7 of 13 checks passed
@jlewitt1 jlewitt1 deleted the update-default-logger branch August 28, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants