logger + log level updates #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
update-default-logger
branch
from
c7e7362
to
e5eb1f0
Compare
jlewitt1
force-pushed
the
update-default-logger
branch
from
e5eb1f0
to
2cb2773
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
2 times, most recently
from
9fa2713
to
aa20a92
Compare
# Conflicts: # runhouse/servers/http/http_client.py
jlewitt1
force-pushed
the
log-level-updates
branch
from
aa20a92
to
70f376d
Compare
jlewitt1
force-pushed
the
update-default-logger
branch
from
2cb2773
to
7b883cc
Compare
# Conflicts: # runhouse/logger.py
jlewitt1
force-pushed
the
log-level-updates
branch
3 times, most recently
from
859613f
to
5f3e17a
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
from
5f3e17a
to
0b8428a
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
3 times, most recently
from
94166b3
to
a1ea931
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
from
a1ea931
to
9b372e0
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
2 times, most recently
from
6eede41
to
0043372
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
6 times, most recently
from
54ca57d
to
0c5d386
Compare
jlewitt1
force-pushed
the
log-level-updates
branch
from
0c5d386
to
510f437
Compare
# Conflicts: # runhouse/resources/hardware/cluster_factory.py
rohinb2
reviewed
Aug 27, 2024
rohinb2
reviewed
Aug 27, 2024
jlewitt1
force-pushed
the
log-level-updates
branch
from
4e7bab9
to
f131cbf
Compare
rohinb2
reviewed
Aug 27, 2024
| @@ -379,6 +379,7 @@ def docker_cluster_pk_ssh(request, test_org_rns_folder): | |||
| ], | |||
| working_dir=None, | |||
| name="default_env", | |||
| env_vars={"RH_LOG_LEVEL": os.getenv("RH_LOG_LEVEL") or TESTING_LOG_LEVEL}, | |||
There was a problem hiding this comment.
oh if you set this locally will it propagate server side?
There was a problem hiding this comment.
yea as part of the restart flow / env.to(cluster)
# Conflicts: # runhouse/servers/cluster_servlet.py
jlewitt1
force-pushed
the
log-level-updates
branch
from
f131cbf
to
218312d
Compare
# Conflicts: # examples/airflow-torch-training/callables.py
|
|
Graphite Automations"rohin" took an action on this PR • (08/27/24)1 gif was posted to this PR based on Rohin Bhasin's automation. |
Merge activity
|
rohinb2
changed the base branch from
update-default-logger
to
graphite-base/1178
# Conflicts: # runhouse/logger.py # runhouse/servers/obj_store.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set log level on cluster according to local
RH_LOG_LEVELenv var. If not set use the default