Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run everything via ssh + docker exec as opposed to SSH Proxy. #1235

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Sep 5, 2024

No description provided.

Copy link

sentry-io bot commented Sep 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
_sync_runhouse_to_cluster ValueError: Error installing runhouse on cluster node <34.229.108.213> ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@rohinb2 rohinb2 changed the title Docker exec directly into container. Run everything via ssh + docker exec as opposed to SSH Proxy. Sep 5, 2024
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch 2 times, most recently from 46b2c40 to 7e56683 Compare September 6, 2024 15:09
@rohinb2 rohinb2 changed the base branch from main to 09-06-Install_from_explicit_dest_path_instead_of_relative_path September 6, 2024 15:09
@rohinb2 rohinb2 force-pushed the 09-06-Install_from_explicit_dest_path_instead_of_relative_path branch from bc55fd1 to e0f1735 Compare September 9, 2024 18:42
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch from 7e56683 to 288e5be Compare September 9, 2024 18:42
@rohinb2 rohinb2 changed the base branch from 09-06-Install_from_explicit_dest_path_instead_of_relative_path to 09-05-Switch_ondemand_aws_cluster_to_ondemand_aws_docker_cluster_ September 9, 2024 18:42
@jlewitt1 jlewitt1 force-pushed the 09-05-Switch_ondemand_aws_cluster_to_ondemand_aws_docker_cluster_ branch from 2e6c4df to 006eeb6 Compare September 9, 2024 19:35
@jlewitt1 jlewitt1 force-pushed the 09-04-Docker_exec_directly_into_container branch from 288e5be to 8b19ed5 Compare September 9, 2024 19:36
@rohinb2 rohinb2 force-pushed the 09-05-Switch_ondemand_aws_cluster_to_ondemand_aws_docker_cluster_ branch from 006eeb6 to e2c24d5 Compare September 9, 2024 20:44
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch from 8b19ed5 to fb2aef8 Compare September 9, 2024 20:44
@rohinb2 rohinb2 force-pushed the 09-05-Switch_ondemand_aws_cluster_to_ondemand_aws_docker_cluster_ branch from e2c24d5 to 1d0b39c Compare September 11, 2024 19:54
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch from fb2aef8 to 53f8776 Compare September 11, 2024 19:54
@rohinb2 rohinb2 changed the base branch from 09-05-Switch_ondemand_aws_cluster_to_ondemand_aws_docker_cluster_ to 09-11-Find_logs_dir_correctly September 11, 2024 19:54
This was referenced Sep 11, 2024
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch from 19b3453 to 66b6233 Compare September 11, 2024 20:28
Copy link
Contributor Author

rohinb2 commented Sep 11, 2024

Merge activity

  • Sep 11, 5:04 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Sep 11, 5:09 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 11, 5:10 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 changed the base branch from 09-11-Find_logs_dir_correctly to graphite-base/1235 September 11, 2024 21:05
@rohinb2 rohinb2 changed the base branch from graphite-base/1235 to main September 11, 2024 21:07
@rohinb2 rohinb2 force-pushed the 09-04-Docker_exec_directly_into_container branch from 66b6233 to 3fa2023 Compare September 11, 2024 21:08
@rohinb2 rohinb2 merged commit df43988 into main Sep 11, 2024
12 of 13 checks passed
@rohinb2 rohinb2 deleted the 09-04-Docker_exec_directly_into_container branch September 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants