Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support starting in docker container for on-demand cluster #803

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

carolineechen
Copy link
Collaborator

No description provided.

Copy link

sentry-io bot commented May 16, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
__init__ AttributeError: module 'sky' has no attribute 'global_user_state' __m...
Event Count: 4
__init__ NameError: name 'sky' is not defined main in ...
Event Count: 2
__init__ AttributeError: module 'sky' has no attribute 'global_user_state' main in initialize_sel...
Event Count: 2
__init__ NameError: name 'sky' is not defined main in ...
Event Count: 2
__init__ NameError: name 'sky' is not defined main in ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

carolineechen commented May 16, 2024

@carolineechen carolineechen force-pushed the cc/docker-env branch 3 times, most recently from 8cf71bd to fcd5cd8 Compare May 22, 2024 19:02
@carolineechen carolineechen force-pushed the cc/docker-env branch 2 times, most recently from 0004acb to a4bfe27 Compare May 30, 2024 15:16
@carolineechen carolineechen changed the base branch from main to cc/pip-install May 30, 2024 15:17
Base automatically changed from cc/pip-install to main May 30, 2024 16:14
@carolineechen carolineechen marked this pull request as ready for review May 30, 2024 19:31
@carolineechen carolineechen force-pushed the cc/docker-env branch 2 times, most recently from cbee37a to b21a8eb Compare June 6, 2024 21:57
@carolineechen carolineechen changed the base branch from main to cc/package-to June 6, 2024 21:57
@carolineechen carolineechen force-pushed the cc/docker-env branch 2 times, most recently from 72d6e0d to e294372 Compare June 10, 2024 20:00
Base automatically changed from cc/package-to to main June 18, 2024 16:37
@carolineechen carolineechen merged commit 794d39a into main Jun 18, 2024
9 of 11 checks passed
@carolineechen carolineechen deleted the cc/docker-env branch June 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants