Add sky env vars support for private docker registries #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/on_demand_cluster.py
Did you find this useful? React with a 👍 or 👎 |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
This was referenced May 30, 2024
Merged
carolineechen
force-pushed
the
cc/docker-env
branch
2 times, most recently
from
cbee37a
to
b21a8eb
Compare
carolineechen
force-pushed
the
cc/docker-env-vars
branch
from
75d09af
to
c74bbed
Compare
This was referenced Jun 6, 2024
Merged
carolineechen
force-pushed
the
cc/docker-env
branch
2 times, most recently
from
72d6e0d
to
e294372
Compare
carolineechen
force-pushed
the
cc/docker-env
branch
from
e294372
to
a0703aa
Compare
carolineechen
force-pushed
the
cc/docker-env-vars
branch
from
c74bbed
to
e6aaf98
Compare
Merged
| ssh_mode=SshMode.INTERACTIVE, port_forward=None | ||
| ) | ||
| subprocess.run( | ||
| " ".join(ssh_command), |
There was a problem hiding this comment.
Should this be a shlex join or is it already properly escaped from inside the command runner?
dongreenberg
approved these changes
Jun 18, 2024
dongreenberg
force-pushed
the
cc/docker-env
branch
from
a0703aa
to
0a832a4
Compare
dongreenberg
force-pushed
the
cc/docker-env-vars
branch
from
e6aaf98
to
3d9876a
Compare
carolineechen
force-pushed
the
cc/docker-env-vars
branch
from
3d9876a
to
cd4b8b4
Compare
carolineechen
force-pushed
the
cc/docker-env
branch
from
0a832a4
to
4d6034b
Compare
carolineechen
force-pushed
the
cc/docker-env-vars
branch
from
cd4b8b4
to
35a46d3
Compare
carolineechen
force-pushed
the
cc/docker-env-vars
branch
from
35a46d3
to
ee865a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.