-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove port_forward
arg in cluster.run
.
#934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/cluster.py
Did you find this useful? React with a 👍 or 👎 |
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 25, 2024 19:59
df69617
to
249391f
Compare
rohinb2
changed the base branch from
main
to
06-25-Don_t_allow_both_env_and_node_to_be_specified_in_cluster.run_
June 25, 2024 19:59
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 25, 2024 20:21
249391f
to
8463e0a
Compare
rohinb2
changed the base branch from
06-25-Don_t_allow_both_env_and_node_to_be_specified_in_cluster.run_
to
06-25-Restructure_cluster.run_to_be_more_clear
June 25, 2024 20:21
This was referenced Jun 25, 2024
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 25, 2024 20:32
9060472
to
4cba019
Compare
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 25, 2024 20:32
8463e0a
to
5de3ec2
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 26, 2024 22:36
4cba019
to
3d54c0c
Compare
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 26, 2024 22:37
5de3ec2
to
84e5963
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 27, 2024 23:06
3d54c0c
to
edb0bf4
Compare
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 27, 2024 23:06
84e5963
to
69ce091
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 27, 2024 23:32
edb0bf4
to
1cea848
Compare
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 27, 2024 23:32
69ce091
to
d02d1a7
Compare
rohinb2
changed the base branch from
06-25-Restructure_cluster.run_to_be_more_clear
to
disallow-node-on-this-cluster
June 27, 2024 23:32
rohinb2
force-pushed
the
disallow-node-on-this-cluster
branch
from
June 30, 2024 21:39
0976b5e
to
44849ad
Compare
rohinb2
force-pushed
the
06-25-Remove_port_forward_arg_in_cluster.run_
branch
from
June 30, 2024 21:41
d02d1a7
to
8533cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why we need this. Maybe I should just deprecate it.. but very very much doubt anyone is using it.