Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove port_forward arg in cluster.run. #934

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jun 25, 2024

Not sure why we need this. Maybe I should just deprecate it.. but very very much doubt anyone is using it.

Copy link

sentry-io bot commented Jun 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
run ValueError: Error checking server: Internal Server Error. Is the server running? ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from df69617 to 249391f Compare June 25, 2024 19:59
@rohinb2 rohinb2 changed the base branch from main to 06-25-Don_t_allow_both_env_and_node_to_be_specified_in_cluster.run_ June 25, 2024 19:59
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from 249391f to 8463e0a Compare June 25, 2024 20:21
@rohinb2 rohinb2 changed the base branch from 06-25-Don_t_allow_both_env_and_node_to_be_specified_in_cluster.run_ to 06-25-Restructure_cluster.run_to_be_more_clear June 25, 2024 20:21
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 9060472 to 4cba019 Compare June 25, 2024 20:32
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from 8463e0a to 5de3ec2 Compare June 25, 2024 20:32
@rohinb2 rohinb2 marked this pull request as ready for review June 25, 2024 21:22
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 4cba019 to 3d54c0c Compare June 26, 2024 22:36
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from 5de3ec2 to 84e5963 Compare June 26, 2024 22:37
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 3d54c0c to edb0bf4 Compare June 27, 2024 23:06
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from 84e5963 to 69ce091 Compare June 27, 2024 23:06
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from edb0bf4 to 1cea848 Compare June 27, 2024 23:32
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from 69ce091 to d02d1a7 Compare June 27, 2024 23:32
@rohinb2 rohinb2 changed the base branch from 06-25-Restructure_cluster.run_to_be_more_clear to disallow-node-on-this-cluster June 27, 2024 23:32
Copy link
Contributor Author

rohinb2 commented Jun 30, 2024

Merge activity

  • Jun 30, 5:33 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jun 30, 5:42 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 30, 5:43 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the disallow-node-on-this-cluster branch from 0976b5e to 44849ad Compare June 30, 2024 21:39
Base automatically changed from disallow-node-on-this-cluster to main June 30, 2024 21:41
@rohinb2 rohinb2 force-pushed the 06-25-Remove_port_forward_arg_in_cluster.run_ branch from d02d1a7 to 8533cf8 Compare June 30, 2024 21:41
@rohinb2 rohinb2 merged commit 67f218d into main Jun 30, 2024
12 of 13 checks passed
@rohinb2 rohinb2 deleted the 06-25-Remove_port_forward_arg_in_cluster.run_ branch June 30, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant