Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure cluster.run to be more clear. #937

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jun 25, 2024

don't really need the self.on_this_cluster() section anymore.

to me it looks like -- default_env will always be set to something, and so we'll use self.call for all the on_this_cluster stuff, which will branch in there on its own.

Copy link

sentry-io bot commented Jun 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
run ValueError: Error checking server: Internal Server Error. Is the server running? ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

@rohinb2 rohinb2 force-pushed the 06-25-No_longer_save_the_run_of_anything_run_via_ssh branch from f465886 to ccfa5d7 Compare June 25, 2024 20:32
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 9060472 to 4cba019 Compare June 25, 2024 20:32
@rohinb2 rohinb2 marked this pull request as ready for review June 25, 2024 21:22
@rohinb2 rohinb2 force-pushed the 06-25-No_longer_save_the_run_of_anything_run_via_ssh branch from ccfa5d7 to 9392992 Compare June 26, 2024 22:36
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 4cba019 to 3d54c0c Compare June 26, 2024 22:36
@rohinb2 rohinb2 force-pushed the 06-25-No_longer_save_the_run_of_anything_run_via_ssh branch from 9392992 to d1f4c43 Compare June 27, 2024 23:06
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch 2 times, most recently from edb0bf4 to 1cea848 Compare June 27, 2024 23:32
Copy link
Contributor Author

rohinb2 commented Jun 30, 2024

Merge activity

  • Jun 30, 5:33 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jun 30, 5:36 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 30, 5:38 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the 06-25-No_longer_save_the_run_of_anything_run_via_ssh branch from d1f4c43 to b870708 Compare June 30, 2024 21:34
Base automatically changed from 06-25-No_longer_save_the_run_of_anything_run_via_ssh to main June 30, 2024 21:35
@rohinb2 rohinb2 force-pushed the 06-25-Restructure_cluster.run_to_be_more_clear branch from 1cea848 to 534b6c5 Compare June 30, 2024 21:36
@rohinb2 rohinb2 merged commit 1905cc6 into main Jun 30, 2024
13 checks passed
@rohinb2 rohinb2 deleted the 06-25-Restructure_cluster.run_to_be_more_clear branch June 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant