-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure cluster.run
to be more clear.
#937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/cluster.py
Did you find this useful? React with a 👍 or 👎 |
This was referenced Jun 25, 2024
rohinb2
force-pushed
the
06-25-No_longer_save_the_run_of_anything_run_via_ssh
branch
from
June 25, 2024 20:32
f465886
to
ccfa5d7
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 25, 2024 20:32
9060472
to
4cba019
Compare
rohinb2
force-pushed
the
06-25-No_longer_save_the_run_of_anything_run_via_ssh
branch
from
June 26, 2024 22:36
ccfa5d7
to
9392992
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 26, 2024 22:36
4cba019
to
3d54c0c
Compare
rohinb2
force-pushed
the
06-25-No_longer_save_the_run_of_anything_run_via_ssh
branch
from
June 27, 2024 23:06
9392992
to
d1f4c43
Compare
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
2 times, most recently
from
June 27, 2024 23:32
edb0bf4
to
1cea848
Compare
rohinb2
force-pushed
the
06-25-No_longer_save_the_run_of_anything_run_via_ssh
branch
from
June 30, 2024 21:34
d1f4c43
to
b870708
Compare
Base automatically changed from
06-25-No_longer_save_the_run_of_anything_run_via_ssh
to
main
June 30, 2024 21:35
rohinb2
force-pushed
the
06-25-Restructure_cluster.run_to_be_more_clear
branch
from
June 30, 2024 21:36
1cea848
to
534b6c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't really need the
self.on_this_cluster()
section anymore.to me it looks like --
default_env
will always be set to something, and so we'll useself.call
for all theon_this_cluster
stuff, which will branch in there on its own.