feat: implement filters for MongoDBAtlasVectorSearch #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thucpn
commented
Aug 30, 2024
thucpn
commented
- Able to populate metadata fields that need for filtering (Done)
- Build mongodb filters based on operator (TODO)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d8c24ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thucpn
changed the title
thucpn
commented
Aug 30, 2024
| similarity: "cosine", | ||
| }; | ||
|
|
||
| // TODO: Build filters based on the operator |
There was a problem hiding this comment.
TODO: Build filters based on the operator
There was a problem hiding this comment.
yes, good idea to add this to the PR too
@llamaindex/autotool
@llamaindex/cloud
@llamaindex/community
@llamaindex/core
@llamaindex/env
@llamaindex/experimental
@llamaindex/wasm-tools
llamaindex
commit: |
| similarity: "cosine", | ||
| }; | ||
|
|
||
| // TODO: Build filters based on the operator |
There was a problem hiding this comment.
yes, good idea to add this to the PR too
packages/llamaindex/src/storage/vectorStore/MongoDBAtlasVectorStore.ts
Outdated
Show resolved
Hide resolved
| @@ -60,8 +60,7 @@ function toMongoDBFilter(filters?: MetadataFilters): Record<string, any> { | |||
| return { $or: filters.filters.map(createFilterObject) }; | |||
| } | |||
|
|
|||
| console.debug("filters.condition not recognized. Returning empty object"); | |||
| return {}; | |||
| throw new Error("filters condition not recognized. Returning empty object"); | |||
There was a problem hiding this comment.
Returning empty object doesn't make sense anymore, how about:
Suggested change
| throw new Error("filters condition not recognized. Returning empty object"); | |
| throw new Error("filters condition not recognized. Must be AND or OR"); |
marcusschiesser
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.