Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement filters for MongoDBAtlasVectorSearch #1142

Merged
merged 10 commits into from
Sep 5, 2024
Merged

feat: implement filters for MongoDBAtlasVectorSearch #1142

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e50897
feat: implement filters for MongoDB
thucpn Aug 30, 2024
6a1b133
remove log
thucpn Aug 30, 2024
abf699d
Create red-vans-taste.md
thucpn Aug 30, 2024
f24cc74
update example
thucpn Aug 30, 2024
a624546
feat: update mongodb example
thucpn Sep 5, 2024
6fa71a5
feat: build filters by operator
thucpn Sep 5, 2024
466939d
fix: able to config embedding definition
thucpn Sep 5, 2024
93791f6
remove log
thucpn Sep 5, 2024
5cc7497
throw error when filters condition not found
thucpn Sep 5, 2024
d8c24ea
fix: doc
thucpn Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/llamaindex/src/storage/vectorStore/MongoDBAtlasVectorStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ function toMongoDBFilter(filters?: MetadataFilters): Record<string, any> {
return { $or: filters.filters.map(createFilterObject) };
}

console.debug("filters.condition not recognized. Returning empty object");
return {};
throw new Error("filters condition not recognized. Returning empty object");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning empty object doesn't make sense anymore, how about:

Suggested change
throw new Error("filters condition not recognized. Returning empty object");
throw new Error("filters condition not recognized. Must be AND or OR");

}

/**
Expand Down