Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get modified Azure DevOps PR files from commit and changes API endpoint #1521

Merged
merged 2 commits into from
May 5, 2021
Merged

Get modified Azure DevOps PR files from commit and changes API endpoint #1521

merged 2 commits into from
May 5, 2021

Conversation

mhennecke
Copy link
Contributor

  1. Get all commits of PR
  2. Get changed files all PR commits

Fixes #1397

@mhennecke mhennecke requested a review from a team as a code owner April 22, 2021 21:23
@lkysow
Copy link
Member

lkysow commented Apr 23, 2021

Hi, you'll need to ensure you rebase off of the latest master branch since we've made some changes to your CI.

@the-cashman
Copy link

Any chance this PR can get approved soon? This would save some of our devs literally hours of manually specifying terraform modules to run in PR's with extensive commits.

acastle
acastle suggested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mhennecke, sorry for the slow turn around here. I just left a couple of comments on your changes and then we can get this merged.

Thanks!

server/events/vcs/azuredevops_client.go Outdated Show resolved Hide resolved
server/events/vcs/azuredevops_client.go Outdated Show resolved Hide resolved
@mhennecke
Copy link
Contributor Author

@acastle Thanks for the review. I added wrapped errors. Please have a look and let me know if you spot anything else that needs fixing.

acastle
acastle approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @mhennecke thanks for your work on this!

@acastle acastle merged commit 1777be4 into runatlantis:master May 5, 2021
This was referenced May 6, 2021
Closed
Merged
@mhennecke mhennecke deleted the fix-1397 branch May 11, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acastle acastle acastle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mhennecke @lkysow @the-cashman @acastle @mariushennecke-abb