Set GitHub app to use slug to make --hide-prev-plan-comments more reliable #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
force-pushed
the
fix-gh-app-user-as-slug
branch
from
5481396 to
231a4ce
Compare
nitrocode
approved these changes
Nov 19, 2022
krrrr38
changed the title
jamengual
reviewed
Nov 20, 2022
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
nitrocode
changed the title
krrrr38
added a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…ts correctly (runatlantis#2697) * Fix GitHub app uses slug as user name * Update server/events/vcs/github_credentials_test.go Co-authored-by: PePe Amengual <jose.amengual@gmail.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
(c *GithubAppCredentials) GetUser()is used only for--hide-prev-plan-comments. However when using GitHub app, comments doesn't hide if we use spefic names which contains upper case, spaces and period. This is because GitHub use commend user name likesome-user-com[bot], notSome User.com[bot].We can get slug name from app.Slug.
Check
My Atlantis.app--hide-prev-plan-commentsdoesn't work if Github App name contains a period #2695--hide-prev-plan-commentsflag fails if using Github App name with uppercased or space chars #1161