Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GitHub app to use slug to make --hide-prev-plan-comments more reliable #2697

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Set GitHub app to use slug to make --hide-prev-plan-comments more reliable #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
231a4ce
Fix GitHub app uses slug as user name
krrrr38 Nov 19, 2022
c581f42
Update server/events/vcs/github_credentials_test.go
nitrocode Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/events/vcs/github_credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func (c *GithubAppCredentials) GetUser() (string, error) {
}
// Currently there is no way to get the bot's login info, so this is a
// hack until Github exposes that.
return fmt.Sprintf("%s[bot]", app.GetName()), nil
return fmt.Sprintf("%s[bot]", app.GetSlug()), nil
}

// GetToken returns a fresh installation token.
Expand Down
2 changes: 1 addition & 1 deletion server/events/vcs/github_credentials_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestGithubClient_GetUser_AppSlug(t *testing.T) {
user, err := appCreds.GetUser()
Ok(t, err)

Assert(t, user == "Octocat App[bot]", "user should not empty")
Assert(t, user == "octoapp[bot]", "user should not be empty")
}

func TestGithubClient_AppAuthentication(t *testing.T) {
Expand Down