Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separate docker image types in matrix, add debian #2770

Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat: Separate docker image types in matrix, add debian #2770

merged 1 commit into from
Dec 12, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 11, 2022 •
edited
Loading

what

  • Add debian docker-base
  • Add matrix job with both alpine and debian
  • Keep old tags for alpine backwards compatibility
  • Add new tags with -{{ image_type }} suffix

why

  • Backwards compatible release tags so new image types will get suffixed with the respective image type
  • New tag atlantis:dev-alpine

references

@nitrocode nitrocode requested a review from a team as a code owner December 11, 2022 16:42
@nitrocode nitrocode force-pushed the separate-alpine-image branch from 7b044ec to 53b7e26 Compare December 11, 2022 16:48
@nitrocode nitrocode changed the title Separate alpine image Separate docker image types in matrix Dec 11, 2022
@nitrocode nitrocode force-pushed the separate-alpine-image branch 3 times, most recently from aee0ad6 to 352c8df Compare December 11, 2022 19:33
@nitrocode nitrocode force-pushed the separate-alpine-image branch 4 times, most recently from bfb36f1 to 539d751 Compare December 12, 2022 02:13
@nitrocode nitrocode force-pushed the separate-alpine-image branch from 539d751 to 191fa86 Compare December 12, 2022 02:15
@nitrocode nitrocode merged commit 5773945 into runatlantis:main Dec 12, 2022
@nitrocode nitrocode deleted the separate-alpine-image branch December 12, 2022 02:22
This was referenced Dec 12, 2022
Merged
Merged
Merged
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
Separate alpine image (runatlantis#2770)
18af229
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
@nitrocode nitrocode changed the title Separate docker image types in matrix Separate docker image types in matrix, add debian Jan 16, 2023
@nitrocode nitrocode changed the title Separate docker image types in matrix, add debian feat: Separate docker image types in matrix, add debian Jan 16, 2023
@nitrocode nitrocode mentioned this pull request Jan 16, 2023
Open
7 tasks
dpiddock added a commit to dpiddock/atlantis that referenced this pull request Jan 27, 2023
@dpiddock
Fix docker-entrypoint when called with atlantis
4e2f464 
Prior to v0.22.0 the container could be run with the command `atlantis
server`. However this was broken by runatlantis#2770:
```
Error: unknown command "atlantis" for "atlantis"
```

This PR reverts to previous functionality and matches the comment.
Following calls all work again:
```sh
docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
```
@dpiddock dpiddock mentioned this pull request Jan 27, 2023
Merged
1 task
nitrocode pushed a commit that referenced this pull request Jan 27, 2023
@dpiddock
Fix docker-entrypoint when called with atlantis (#3060)
bbb0ed2 
Prior to v0.22.0 the container could be run with the command `atlantis
server`. However this was broken by #2770:
```
Error: unknown command "atlantis" for "atlantis"
```

This PR reverts to previous functionality and matches the comment.
Following calls all work again:
```sh
docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
```
DragosDumitrache pushed a commit to gocardless/atlantis that referenced this pull request Jan 30, 2023
@dpiddock
Fix docker-entrypoint when called with atlantis (runatlantis#3060)
65286b0 
Prior to v0.22.0 the container could be run with the command `atlantis
server`. However this was broken by runatlantis#2770:
```
Error: unknown command "atlantis" for "atlantis"
```

This PR reverts to previous functionality and matches the comment.
Following calls all work again:
```sh
docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
```
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual