Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): docker-entrypoint when called with atlantis #3060

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(docker): docker-entrypoint when called with atlantis #3060

merged 1 commit into from
Jan 27, 2023

Conversation

dpiddock
Copy link
Contributor

@dpiddock dpiddock commented Jan 27, 2023 •
edited
Loading

what

Restore functionality of calling the container with commands starting atlantis

why

Prior to v0.22.0 the container could be run with the command atlantis server. However this was broken by #2770:

Error: unknown command "atlantis" for "atlantis"

tests

  • I have tested my changes by running the following commands

This PR reverts to previous functionality and matches the comment. Following calls all work again:

docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
hadolint Dockerfile

produced no output but I didn't modify that file.

references

@dpiddock
Fix docker-entrypoint when called with atlantis
4e2f464 
Prior to v0.22.0 the container could be run with the command `atlantis
server`. However this was broken by runatlantis#2770:
```
Error: unknown command "atlantis" for "atlantis"
```

This PR reverts to previous functionality and matches the comment.
Following calls all work again:
```sh
docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
```
@dpiddock dpiddock requested a review from a team as a code owner January 27, 2023 12:08
@nitrocode nitrocode added this to the v0.23.0 milestone Jan 27, 2023
@nitrocode nitrocode changed the title Fix docker-entrypoint when called with atlantis fix(docker): docker-entrypoint when called with atlantis Jan 27, 2023
@nitrocode nitrocode added the docker Pull requests that update Docker code label Jan 27, 2023
nitrocode
nitrocode approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @dpiddock !

@nitrocode nitrocode merged commit bbb0ed2 into runatlantis:main Jan 27, 2023
@dpiddock dpiddock deleted the fix-entypoint branch January 27, 2023 15:20
DragosDumitrache pushed a commit to gocardless/atlantis that referenced this pull request Jan 30, 2023
@dpiddock
Fix docker-entrypoint when called with atlantis (runatlantis#3060)
65286b0 
Prior to v0.22.0 the container could be run with the command `atlantis
server`. However this was broken by runatlantis#2770:
```
Error: unknown command "atlantis" for "atlantis"
```

This PR reverts to previous functionality and matches the comment.
Following calls all work again:
```sh
docker run atlantis server
docker run atlantis --help
docker run atlantis atlantis server
docker run atlantis atlantis --help
```
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpiddock @nitrocode