Skip to content

Commit

Permalink
fix: remove virtual machine image when running make clean
Browse files Browse the repository at this point in the history
Original message "fix: Fix to remove the virtual machine storage in deps/finch-core/downloads/os by make clean"

Issue #, if available: #537

*Description of changes:*

In finch, when booting a virtual machine using Lima, it is necessary to
download the virtual machine storage in QCOW2 format.

The QCOW2 virtual machine storage thus downloaded and located in
deps/finch-core/downloads/os is not deleted when make clean is run in
the home directory as currently implemented.

This file may be larger than 500 MB in size and is reported in
issue/#537 such that it is expected to be deleted when make clean is
run.

Therefore, this fix will remove the QCOW2 format downloaded files in
deps/finch-core/downloads/os when make clean is run in the home
directory.

*Testing done:* yes

- [x] I've reviewed the guidance in CONTRIBUTING.md

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
Co-authored-by: Hayato Kiwata <haytok@amazon.co.jp>
  • Loading branch information
haytok and haytok authored Nov 7, 2023
1 parent 2537aa6 commit 98c8ee4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ clean:
-sudo rm -rf "/private/etc/sudoers.d/finch-lima"
-@rm -rf $(OUTDIR) 2>/dev/null || true
-@rm -rf ./deps/finch-core/_output || true
-@rm -rf ./deps/finch-core/downloads/os/$(FINCH_OS_BASENAME) || true
-@rm ./*.tar.gz 2>/dev/null || true
-@rm ./*.qcow2 2>/dev/null || true
-@rm ./test-coverage.* 2>/dev/null || true

0 comments on commit 98c8ee4

Please sign in to comment.