Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make clean retains downloads in deps/finch-core #537

Closed
ginglis13 opened this issue Aug 17, 2023 · 1 comment
Closed

make clean retains downloads in deps/finch-core #537

ginglis13 opened this issue Aug 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ginglis13
Copy link
Contributor

Describe the bug
make clean does not clean submodule downloads in deps/finch-core/downloads

Steps to reproduce

make

ls deps/finch-core/downloads/os

make clean

ls deps/finch-core/downloads/os

Expected behavior
I would expect make clean to remove the downloaded OSs as each are > 500mb, or there to at least be a rule such as make deps-clean to remove these. Alternatively, if the idea behind not cleaning these is so that they don't need to keep being redownloaded, the rule could have some regex and/or could be modified by the Sync Submodules and Dependencies action to only delete OS/rootfs that don't match the latest available.
@ginglis13 ginglis13 added the bug Something isn't working label Aug 17, 2023
@ginglis13 ginglis13 changed the title make clean retains OS/rootfs in deps/finch-core make clean retains downloads in deps/finch-core Aug 17, 2023
@haytok
Copy link
Member

haytok commented Nov 3, 2023

Hi, @ginglis13
I would like to work on this issue, so could you please assign me ?

@haytok haytok mentioned this issue Nov 5, 2023
Merged
1 task
pendo324 pushed a commit that referenced this issue Nov 7, 2023
@haytok
fix: remove virtual machine image when running make clean
98c8ee4 
Original message "fix: Fix to remove the virtual machine storage in deps/finch-core/downloads/os by make clean"

Issue #, if available: #537

*Description of changes:*

In finch, when booting a virtual machine using Lima, it is necessary to
download the virtual machine storage in QCOW2 format.

The QCOW2 virtual machine storage thus downloaded and located in
deps/finch-core/downloads/os is not deleted when make clean is run in
the home directory as currently implemented.

This file may be larger than 500 MB in size and is reported in
issue/#537 such that it is expected to be deleted when make clean is
run.

Therefore, this fix will remove the QCOW2 format downloaded files in
deps/finch-core/downloads/os when make clean is run in the home
directory.

*Testing done:* yes

- [x] I've reviewed the guidance in CONTRIBUTING.md

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
Co-authored-by: Hayato Kiwata <haytok@amazon.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ginglis13 @haytok