fix: Fix to delete ~/.finch when uninstalling finch #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, uninstalling finch does not delete the ~/.finch directory. This directory may hold several GB of container data disks, which can consume a lot of space and be left unremoved. This issue has also been reported in issue/#457 and needs to be fixed. Therefore, this fix will ensure that when finch is uninstalled, ~/.finch is also deleted to free up disk space for finch. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
|
Thanks for the contribution! I think since this deals with users' persistent data, it would be better to have it opt in instead when uninstalling, or at least give a prompt for if the user would like to keep their data. |
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
KevinLiAWS
approved these changes
Dec 5, 2023
KevinLiAWS
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2023-12-07) ### Bug Fixes * Clean up all previous finch version installation registries in postinstall and uninstall ([#688](#688)) ([9afc0b9](9afc0b9)) * Fix to be able to run finch build with --ssh option ([#696](#696)) ([4d1e6cf](4d1e6cf)) * Fix to delete ~/.finch when uninstalling finch ([#703](#703)) ([8d7389f](8d7389f)) * remove virtual machine image when running make clean ([98c8ee4](98c8ee4)) * resolve shellcheck warnings ([#684](#684)) ([d9f695a](d9f695a)) * Use LimaUser method instead of host user name ([#712](#712)) ([7c02e08](7c02e08)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
KevinLiAWS
added a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2023-12-11) ### Bug Fixes * Change the default behavoir for deleting .finch folder to false when uninstall ([#732](#732)) ([e818743](e818743)) * Clean up all previous finch version installation registries in postinstall and uninstall ([#688](#688)) ([9afc0b9](9afc0b9)) * Fix to be able to run finch build with --ssh option ([#696](#696)) ([4d1e6cf](4d1e6cf)) * Fix to delete ~/.finch when uninstalling finch ([#703](#703)) ([8d7389f](8d7389f)) * remove virtual machine image when running make clean ([98c8ee4](98c8ee4)) * resolve shellcheck warnings ([#684](#684)) ([d9f695a](d9f695a)) * Use LimaUser method instead of host user name ([#712](#712)) ([7c02e08](7c02e08)) ### Reverts * "fix: resolve shellcheck warnings" ([#725](#725)) ([8ea255a](8ea255a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: Kevin Li <cnkevin@amazon.com> Co-authored-by: Kevin Li <cnkevin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, uninstalling finch does not delete the ~/.finch directory.
This directory may hold several GB of container data disks, which can consume a lot of space and be left unremoved.
This issue has also been reported in issue/#457 and needs to be fixed.
Therefore, this fix will ensure that when finch is uninstalled, ~/.finch is also deleted to free up disk space for finch.
Issue #, if available: issue/#457
Description of changes: Details are described in commit messages.
Testing done: Yes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.