Ignore error if exe doesn't contain RT_VERSION

Resolves #421
russellbanks · Jan 30, 2024 · 910615c · 910615c
1 parent c554269
commit 910615c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/file_analyser.rs b/src/file_analyser.rs
@@ -84,8 +84,9 @@ impl<'a> FileAnalyser<'a> {
  msi = Some(extract_msi(&pe_file)?);
  }
  pe_arch = Some(Architecture::get_from_exe(&pe_file)?);
- string_map = VSVersionInfo::parse(&pe_file, map.as_ref())?
- .string_file_info
+ string_map = VSVersionInfo::parse(&pe_file, map.as_ref())
+ .ok()
+ .and_then(|vs_version_info| vs_version_info.string_file_info)
  .map(|mut string_file_info| {
  string_file_info.children.swap_remove(0).string_map()
  });
@@ -102,8 +103,9 @@ impl<'a> FileAnalyser<'a> {
  msi = Some(extract_msi(&pe_file)?);
  }
  pe_arch = Some(Architecture::get_from_exe(&pe_file)?);
- string_map = VSVersionInfo::parse(&pe_file, map.as_ref())?
- .string_file_info
+ string_map = VSVersionInfo::parse(&pe_file, map.as_ref())
+ .ok()
+ .and_then(|vs_version_info| vs_version_info.string_file_info)
  .map(|mut string_file_info| {
  string_file_info.children.swap_remove(0).string_map()
  });