Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish to winget & homebrew tap #441

Merged
merged 12 commits into from
Feb 15, 2024

Conversation

vedantmgoyal9
Copy link
Contributor

No description provided.

@vedantmgoyal9 vedantmgoyal9 marked this pull request as ready for review February 2, 2024 09:34
@vedantmgoyal9 vedantmgoyal9 changed the title Use winget-releaser to publish stable versions Automatically publish to winget & omebrew tap Feb 2, 2024
@vedantmgoyal9 vedantmgoyal9 changed the title Automatically publish to winget & omebrew tap Automatically publish to winget & homebrew tap Feb 2, 2024
@russellbanks
Copy link
Owner

Can you split this into two separate jobs so that there's a winget job and a homebrew job that both rely on the release workflow. This means they could both run at the same time and they'd be more defined in what they're doing. It also means it would be easier to copy if other jobs need to be added for other package managers.

@CoolPlayLin
Copy link

@vedantmgoyal2009
Is it possible that this workflow can include nightly version publishing?

@CoolPlayLin
Copy link

image
It seems nightly version hasn't maintained for days

@vedantmgoyal9
Copy link
Contributor Author

Nightly releases were automatically updated by @wingetbot. Looks like it has been offline from last 2 months - https://github.com/microsoft/winget-pkgs/commits/master/manifests/r/RussellBanks/Komac/Nightly.

@CoolPlayLin
Copy link

Looks good

@vedantmgoyal9
Copy link
Contributor Author

Please wait until the following PRs get merged, else InstallerSha256 will become invalid.

@CoolPlayLin
Copy link

CoolPlayLin commented Feb 2, 2024

I think this Pull Request hasn't modified any source code. So, merging this Pull Request would not get Sha256 invalid. It can be merged directly

@vedantmgoyal9
Copy link
Contributor Author

Merging this PR will update binaries at nightly tag, and hence, winget pipelines will fail.

@vedantmgoyal9
Copy link
Contributor Author

The latest commit fixes the issue. Now it can be merged directly.

@vedantmgoyal9
Copy link
Contributor Author

Well, the PRs which don't change source code doesn't affect Komac, and hence, there is no need to run Github Actions on them.

@CoolPlayLin

This comment was marked as outdated.

@CoolPlayLin
Copy link

I think it is necessary to run action when someone modified the workflow. You would not know what will it happed until you run it

@vedantmgoyal9
Copy link
Contributor Author

Done 👍🏻

@vedantmgoyal9
Copy link
Contributor Author

If the new workflow changes source-code, then the other triggers will automatically run the build & test workflow, which in turn will trigger release workflow, once it gets completed.

@russellbanks
Copy link
Owner

I don't want to publish nightly releases myself because the hash will likely change before msft bot is able to process it

@vedantmgoyal9
Copy link
Contributor Author

We don't need cargo build, test and release worflows to test a github workflow 😂

@vedantmgoyal9
Copy link
Contributor Author

I don't want to publish nightly releases myself because the hash will likely change before msft bot is able to process it

It is a temporary addition, since Microsoft's wingetbot is not working.

@CoolPlayLin
Copy link

We don't need cargo build, test and release worflows to test a github workflow 😂

Sorry for my stupid thoughts😂

@vedantmgoyal9
Copy link
Contributor Author

This can be merged now as microsoft/winget-pkgs#137631 is merged.

@vedantmgoyal9
Copy link
Contributor Author

I've updated to macos-14 so that we get komac tested on M1-macOS.

@russellbanks
Copy link
Owner

russellbanks commented Feb 15, 2024

I've updated to macos-14 so that we get komac tested on M1-macOS.

Wouldn't that be best for the build and test workflow rather than this job that releases on winget (although I'm not overly concerned unless it would help to be built on an M1-macOS as macos-latest will use macos-14 eventually)? ubuntu-latest will likely be faster and I try to use it when I don't need anything specific from any other platform.

@russellbanks russellbanks merged commit 5f6ab43 into russellbanks:main Feb 15, 2024
3 checks passed
@vedantmgoyal9 vedantmgoyal9 deleted the patch-1 branch February 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants