-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically publish to winget & homebrew tap #441
Conversation
Can you split this into two separate jobs so that there's a winget job and a homebrew job that both rely on the release workflow. This means they could both run at the same time and they'd be more defined in what they're doing. It also means it would be easier to copy if other jobs need to be added for other package managers. |
@vedantmgoyal2009 |
Nightly releases were automatically updated by @wingetbot. Looks like it has been offline from last 2 months - https://github.com/microsoft/winget-pkgs/commits/master/manifests/r/RussellBanks/Komac/Nightly. |
Looks good |
Please wait until the following PRs get merged, else InstallerSha256 will become invalid. |
I think this Pull Request hasn't modified any source code. So, merging this Pull Request would not get Sha256 invalid. It can be merged directly |
Merging this PR will update binaries at nightly tag, and hence, winget pipelines will fail. |
The latest commit fixes the issue. Now it can be merged directly. |
Well, the PRs which don't change source code doesn't affect Komac, and hence, there is no need to run Github Actions on them. |
This comment was marked as outdated.
This comment was marked as outdated.
I think it is necessary to run action when someone modified the workflow. You would not know what will it happed until you run it |
Done 👍🏻 |
If the new workflow changes source-code, then the other triggers will automatically run the build & test workflow, which in turn will trigger release workflow, once it gets completed. |
I don't want to publish nightly releases myself because the hash will likely change before msft bot is able to process it |
We don't need cargo build, test and release worflows to test a github workflow 😂 |
It is a temporary addition, since Microsoft's wingetbot is not working. |
Sorry for my stupid thoughts😂 |
This can be merged now as microsoft/winget-pkgs#137631 is merged. |
I've updated to macos-14 so that we get komac tested on M1-macOS. |
Wouldn't that be best for the build and test workflow rather than this job that releases on winget (although I'm not overly concerned unless it would help to be built on an M1-macOS as |
No description provided.