Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action-semantic-pull-request does not accept 'deps' as type #59

Closed
dcroote opened this issue Jul 11, 2023 · 0 comments · Fixed by #61
Closed

action-semantic-pull-request does not accept 'deps' as type #59

dcroote opened this issue Jul 11, 2023 · 0 comments · Fixed by #61
Assignees

Comments

@dcroote
Copy link
Contributor

dcroote commented Jul 11, 2023

The conventional-prs.yml Actions workflow, which uses amannn/action-semantic-pull-request, does not accept deps (which we want for release-please) as a commit type as shown by the CI failure from #58:

Unknown release type "deps" found in pull request title "deps: bump serde from 1.0.136 to 1.0.156". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

The available types are configurable though (https://github.com/amannn/action-semantic-pull-request#configuration) and I will open a PR to add deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant