Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: allow deps as semantic PR title prefix #61

Merged
merged 1 commit into from
Jul 12, 2023
Merged

ci: allow deps as semantic PR title prefix #61

merged 1 commit into from
Jul 12, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Jul 12, 2023

Closes #59 and specifies additional changelog / release sections.

@dcroote
ci: allow deps as semantic PR title prefix
344ec91 
This also bumps the amannn/action-semantic-pull-request action version

ci: bump release-please action version and specify section types
@dcroote dcroote self-assigned this Jul 12, 2023
@dcroote dcroote requested a review from dlaehnemann July 12, 2023 05:00
@dcroote dcroote mentioned this pull request Jul 12, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5527723586

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.477%
Totals Coverage Status
Change from base Build 5527472037: 0.0%
Covered Lines: 471
Relevant Lines: 742
💛 - Coveralls

dlaehnemann
dlaehnemann approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for digging into this!

@dlaehnemann dlaehnemann merged commit 907b3d9 into master Jul 12, 2023
8 checks passed
@dlaehnemann dlaehnemann deleted the dcroote/issue59 branch July 12, 2023 08:43
@dcroote
Copy link
Contributor Author

dcroote commented Jul 12, 2023

This solved the issues:

  1. PR title action step is now passing after a rebase onto the latest master: deps: bump serde from 1.0.136 to 1.0.171 #60
  2. The release changelog includes dependencies: chore(master): release 1.0.1 #62

@dcroote dcroote mentioned this pull request Dec 20, 2023
Closed
@dcroote dcroote mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaehnemann dlaehnemann dlaehnemann approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

action-semantic-pull-request does not accept 'deps' as type
3 participants
@dcroote @coveralls @dlaehnemann