Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dependabot commit message follow conventional commits #542

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

dlaehnemann
Copy link
Member

@dlaehnemann dlaehnemann mentioned this pull request Jul 10, 2023
@dlaehnemann dlaehnemann requested a review from dcroote July 10, 2023 09:21
@dlaehnemann
Copy link
Member Author

Also, I filed an issue with the current CI Coverage step failure, as the error message requested this (and suggested this is some compiler-internal bug).

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Please considers deps a 'releasable unit', but not chore (docs). I think it'd therefore be nicer to prefix with deps so that Release Please includes dependency updates in the release / changelog, like here for example. What do you think?

@dlaehnemann
Copy link
Member Author

Yes, that makes perfect sense. I just looked for what matched our case closest in the conventional commits cheat sheet, but didn't check on release please. Many thanks for this suggestion, I'll amend both PRs accordingly.

@dlaehnemann
Copy link
Member Author

Feel free to merge both, once the tests pass. I think it is currently OK to ignore the Coverage step failure, as this seems to be a nightly compiler bug.

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and your code comment will definitely be helpful for anyone curious about the prefix.

@dcroote dcroote merged commit bb88281 into master Jul 11, 2023
10 of 11 checks passed
@dcroote dcroote deleted the dependabot-conventional-commit-messages branch July 11, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants