Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use embedded-storage BlockDevice trait. #162

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Oct 29, 2024

This will allow both the SD card driver and the FAT32 implementation to be used with filesystem or block device drivers respectively.

This is a step towards #15 and shows off how to use rust-embedded-community/embedded-storage#59 in practice.

@qwandor qwandor force-pushed the embedded-storage-blockdevice branch 2 times, most recently from 45ca173 to 02caa6a Compare October 29, 2024 18:25
@thejpster
Copy link
Member

It's a shame to loose BlockIdx and BlockCount and go back to raw u64 values that you can easily get mixed up.

This will allow both the SD card driver and the FAT32 implementation to
be used with filesystem or block device drivers respectively.
@qwandor qwandor force-pushed the embedded-storage-blockdevice branch from d2581d0 to ee3c688 Compare October 30, 2024 11:47
@elpiel
Copy link
Contributor

elpiel commented Nov 22, 2024

Yep that's a shame, I just saw that they were added*
@qwandor Can't we keep the Block in embedded_storage too and add Deref impl to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants