add support for embedded-hal=1.0.0-alpha.10 - WIP
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasta if your HAL already supports i'll merge this PR once the referenced libraries ( |
rursprung
force-pushed
the
add-eh1-support
branch
from
e2f3dd4 to
8d6126e
Compare
This was
linked to
issues
Jul 2, 2023
Closed
as this version of embedded-hal has added `SetDutyCycle` as the equivalent / successor of the old `PwmPin` support for it can now be added here. open points: * wait for a release of stm32f4xx-hal which includes the `SetDutyCycle` implementation (PR already merged) * wait for a release of embedded-hal-mock which includes the `SetDutyCycle` implementation (PR currently open) fixes #3 fixes #8
this ensures that all expected transactions have been done. this has also uncovered that the expectations in `test_motor_drive_invalid_speed` were wrong, which has now been fixed.
rursprung
force-pushed
the
add-eh1-support
branch
from
8d6126e to
18b8be6
Compare
|
this has been replaced with #25 which has now been released as v0.2.0. note that the new version only supports e-h 1.0.0-rc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commit messages for details