Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support embedded-hal 1.0 #3

Closed
rursprung opened this issue Feb 13, 2023 · 0 comments · Fixed by #25
Closed

support embedded-hal 1.0 #3

rursprung opened this issue Feb 13, 2023 · 0 comments · Fixed by #25
Assignees
@rursprung
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Milestone
release 1.0.0

Comments

@rursprung
Copy link
Collaborator

rursprung commented Feb 13, 2023 •
edited
Loading

rust-embedded/embedded-hal#430 has added an embeded-hal 1.0 alternative to the previous PwmPin. support for it should be added here. to test it we'll also need dbrgn/embedded-hal-mock#73.
@rursprung rursprung added this to the release 1.0.0 milestone Feb 13, 2023
@rursprung rursprung mentioned this issue Feb 13, 2023
Closed
rursprung added a commit that referenced this issue Jul 2, 2023
@rursprung
add support for embedded-hal=1.0.0-alpha.10 - WIP
36d8703 
as this version of embedded-hal has added `SetDutyCycle` as the
equivalent / successor of the old `PwmPin` support for it can now be
added here.

open points:
* wait for a release of stm32f4xx-hal which includes the `SetDutyCycle`
  implementation (PR already merged)
* wait for a release of embedded-hal-mock which includes the
  `SetDutyCycle` implementation (PR currently open)

fixes #3
fixes #8
@rursprung rursprung linked a pull request Jul 2, 2023 that will close this issue
add support for embedded-hal=1.0.0-alpha.10 - WIP #18
Closed
@rursprung rursprung self-assigned this Jul 2, 2023
@rursprung rursprung added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 2, 2023
rursprung added a commit that referenced this issue Jul 6, 2023
@rursprung
add support for embedded-hal=1.0.0-alpha.10 - WIP
8bb1990 
as this version of embedded-hal has added `SetDutyCycle` as the
equivalent / successor of the old `PwmPin` support for it can now be
added here.

open points:
* wait for a release of stm32f4xx-hal which includes the `SetDutyCycle`
  implementation (PR already merged)
* wait for a release of embedded-hal-mock which includes the
  `SetDutyCycle` implementation (PR currently open)

fixes #3
fixes #8
@rursprung rursprung mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rursprung rursprung

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
release 1.0.0
1 participant
@rursprung