Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mock for e-h 1 SetDutyCycle (PwmPin successor) trait #73

Closed
rursprung opened this issue Jun 15, 2023 · 0 comments · Fixed by #88
Closed

add mock for e-h 1 SetDutyCycle (PwmPin successor) trait #73

rursprung opened this issue Jun 15, 2023 · 0 comments · Fixed by #88

Comments

@rursprung
Copy link
Contributor

rursprung commented Jun 15, 2023 •
edited
Loading

rust-embedded/embedded-hal#430 introduced the SetDutyCycle trait as an embedded-hal 1.0 replacement for the previous 0.2 PwmPin (for which a mock implementation exists).
it'd be great to have a mock implementation also for the new trait!

note: #66 already updated this repo to the required e-h 1.0 pre-release.
@rursprung rursprung mentioned this issue Jun 15, 2023
Closed
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Jul 2, 2023
@rursprung
add SetDutyCycle mock
4c4355e 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Jul 2, 2023
@rursprung
add SetDutyCycle mock
a5ed62a 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
@rursprung rursprung mentioned this issue Jul 2, 2023
Closed
tommy-gilligan pushed a commit to tommy-gilligan/embedded-hal-mock that referenced this issue Jul 3, 2023
@rursprung @tommy-gilligan
add SetDutyCycle mock
881e105 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Jul 6, 2023
@rursprung
add SetDutyCycle mock
5987275 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Sep 13, 2023
@rursprung
add SetDutyCycle mock
f935771 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
@rursprung rursprung mentioned this issue Sep 13, 2023
Merged
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Sep 13, 2023
@rursprung
add SetDutyCycle mock
f09123c 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Sep 17, 2023
@rursprung
add SetDutyCycle mock
eb02fe9 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
@cdunster cdunster mentioned this issue Sep 19, 2023
Closed
cdunster pushed a commit to cdunster/embedded-hal-mock that referenced this issue Sep 19, 2023
@rursprung @cdunster
add SetDutyCycle mock
389d77b 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
cdunster pushed a commit to cdunster/embedded-hal-mock that referenced this issue Sep 19, 2023
@rursprung @cdunster
add SetDutyCycle mock
899c9fb 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Nov 2, 2023
@rursprung
add SetDutyCycle mock
f5b3a2c 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
rursprung added a commit to rursprung/embedded-hal-mock that referenced this issue Nov 5, 2023
@rursprung
add SetDutyCycle mock
69d3d82 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
cdunster pushed a commit to cdunster/embedded-hal-mock that referenced this issue Nov 6, 2023
@rursprung @cdunster
add SetDutyCycle mock
ec4b93b 
this is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in dbrgn#52).

note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

this fixes dbrgn#73
@dbrgn dbrgn closed this as completed in #88 Nov 23, 2023
dbrgn pushed a commit that referenced this issue Nov 23, 2023
@rursprung
Add SetDutyCycle mock (#88)
0c2bbf5 
This is the 1.0 equivalent of the old `PwmPin` trait (the mock for this
has been added in #52).

Note that the test coverage is fully handled by the doc test which is
why there's no additional `mod test` in this file.

This fixes #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rursprung